Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Issues #3797

Closed
ElderlyGlek opened this issue Apr 8, 2023 · 13 comments
Closed

Font Issues #3797

ElderlyGlek opened this issue Apr 8, 2023 · 13 comments
Assignees
Labels
Milestone

Comments

@ElderlyGlek
Copy link

ElderlyGlek commented Apr 8, 2023

I don’t think it’s worth listing the changed characters, so I’m attaching a file in which I fixed some font flaws, namely extra spaces and characters that are lower than others:

aseprite_font

Only changed symbols:

aseprite_font_changed_only

In my version "Ё" and "ё" look the same as "Е" and "е" to be at the same height with other characters, "Й" looks the same as "И" for the same reason. As a native speaker of Russian and Ukrainian, I can say that this will not spoil the readability of the text.

@ElderlyGlek
Copy link
Author

You also need to add the characters "Ґ" and "ґ" from Ukrainian language:

G

@dacap dacap self-assigned this Apr 8, 2023
@dacap dacap added the ui label Apr 8, 2023
@dacap dacap added this to the v1.3-rc3 milestone Apr 8, 2023
@dacap
Copy link
Member

dacap commented Apr 8, 2023

Hi @ElderlyGlek, thanks a lot for the help! I'll try to review these changes and integrate it for the next release (probably next week)! I'll make any comment later if it's required.

@ElderlyGlek
Copy link
Author

Hi @ElderlyGlek, thanks a lot for the help! I'll try to review these changes and integrate it for the next release (probably next week)! I'll make any comment later if it's required.

I'm happy to help you, @dacap! By the way, I just edited the post because I forgot to change the "Є" character.

@ElderlyGlek
Copy link
Author

I also changed the symbols "Ф" and "ф".

@dacap dacap closed this as completed in b5f262f May 1, 2023
@dacap
Copy link
Member

dacap commented May 1, 2023

Thanks a lot @ElderlyGlek, I've just integrated the changes to the font. You can find the updated font here: https://raw.githubusercontent.com/aseprite/aseprite/b5f262f4237c7fded6798bd5956f30b4f56d27a7/data/fonts/aseprite_font.png

@ElderlyGlek
Copy link
Author

Thanks a lot @ElderlyGlek, I've just integrated the changes to the font. You can find the updated font here: https://raw.githubusercontent.com/aseprite/aseprite/b5f262f4237c7fded6798bd5956f30b4f56d27a7/data/fonts/aseprite_font.png

Hi, @dacap! I looked at the changes, and noticed that the characters "в", "л", "о" had extra spaces, so here is another corrected file:

aseprite_font

I also didn't like that the character "Ґ" looks lower than the other characters, so I made it the same as the "Г" (similar to "Й" and "И").

@dacap
Copy link
Member

dacap commented May 3, 2023

@ElderlyGlek I'd prefer to wait to incorporate new changes to the font until we receive more feedback from other users (or probably you find new improvements), because changing a binary file on the Git repository several times is something we try to avoid.

@ElderlyGlek
Copy link
Author

@ElderlyGlek I'd prefer to wait to incorporate new changes to the font until we receive more feedback from other users (or probably you find new improvements), because changing a binary file on the Git repository several times is something we try to avoid.

Well, I personally did not notice any problems with the font, the only thing I changed was the characters "У", "у" and "х":

aseprite_font

@ElderlyGlek
Copy link
Author

@ElderlyGlek I'd prefer to wait to incorporate new changes to the font until we receive more feedback from other users (or probably you find new improvements), because changing a binary file on the Git repository several times is something we try to avoid.

Well, I personally did not notice any problems with the font, the only thing I changed was the characters "У", "у" and "х":

aseprite_font

@dacap I forgot to mention you so you probably didn't notice this post.

@dacap
Copy link
Member

dacap commented Jul 24, 2023

Thanks @ElderlyGlek! Sorry for my late response, probably you could take a look to this PR: #3975 there are some extra change that we'd like to introduce too. What do you think?

@EricKotato
Copy link

@dacap
Actually, #3797 (comment) corrects the same problem as my PR, and adds new letters on top of that, so I think it's even better.

@ElderlyGlek
Copy link
Author

Thanks @ElderlyGlek! Sorry for my late response, probably you could take a look to this PR: #3975 there are some extra change that we'd like to introduce too. What do you think?

@dacap I already wrote about extra spaces above, and my corrected version of the font does not have this problem.

dacap added a commit that referenced this issue Jul 24, 2023
* Fixed spacing of "в", "о", and "л".
* Fixed "У", "у", "х" glyphs.
@dacap
Copy link
Member

dacap commented Jul 24, 2023

I've just updated the font with your changes @ElderlyGlek in 392dbd1, thanks to @EricKotato for the help too! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants