Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new shader rotation algorithm #4331

Open
dacap opened this issue Feb 22, 2024 · 6 comments
Open

Add new shader rotation algorithm #4331

dacap opened this issue Feb 22, 2024 · 6 comments
Assignees
Labels
feature Feature request, or something should be improved sprite editor
Milestone

Comments

@dacap
Copy link
Member

dacap commented Feb 22, 2024

With the help of torcado we would like to add their cleanEdge rotation algorithm based on this shaders.

@dacap dacap added feature Feature request, or something should be improved sprite editor labels Feb 22, 2024
@dacap dacap added this to the v1.3.5 milestone Feb 22, 2024
@dacap dacap self-assigned this Feb 22, 2024
@dacap dacap modified the milestones: v1.3.5, v1.3.6 Feb 28, 2024
@dacap dacap modified the milestones: v1.3.6, v1.3.7-beta Mar 8, 2024
@gui-marc
Copy link
Contributor

gui-marc commented Apr 26, 2024

Could this be implemented in the current state of the application? Did some research in the app's code but based on #3516 I guess Aseprite currently cannot use shaders for rendering images.

Am I right or did I miss something?

@dacap
Copy link
Member Author

dacap commented Apr 26, 2024

There are still some work to do. For #3516 we have already something working in the ShaderRenderer class, and for this issue I have a local stash with some code, but they are two independent features (one uses shaders to render sprites, the other uses shaders to modify the sprite).

I'll see if I can push something about this in a draft PR with my local changes.

@gui-marc
Copy link
Contributor

In fact they are two independent features, but can the current ShaderRenderer use shaders to modifty the sprite? I have some interest and experience in CG stuff and would love to help implement that :)

@dacap
Copy link
Member Author

dacap commented Apr 26, 2024

can the current ShaderRenderer use shaders to modifty the sprite?

No, the purpose of the ShaderRenderer is to render the sprite. If you want to create a shader to modify the sprite you have to use the app::make_shader() function defined in shader_helpers.h with your own shader/inputs/outputs (I have some code related to this for this feature, not yet public).

@gui-marc
Copy link
Contributor

(I have some code related to this for this feature, not yet public)

So this feature is almost fully implemented, right? There's any other related issue related to this you think I could help?

@dacap
Copy link
Member Author

dacap commented Apr 26, 2024

No, it's not fully implemented (only on RGB, broken code, the shader wasn't ready, and we required to get the proper transformation matrix yet, and too little time to debug code yet).

Probably you are looking for something much simpler, like just running a shader in a rectangular area (like an FX). You are free to create a new issue to request a new feature in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request, or something should be improved sprite editor
Projects
Status: Todo
Development

No branches or pull requests

2 participants