Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shader-based render engine #3516

Open
1 of 7 tasks
dacap opened this issue Sep 13, 2022 · 0 comments · Fixed by #3523
Open
1 of 7 tasks

Shader-based render engine #3516

dacap opened this issue Sep 13, 2022 · 0 comments · Fixed by #3523
Assignees
@dacap
Labels
feature Feature request, or something should be improved gpu maintenance performance refactor complexity This issue needs some refactor / modifying several files / rethinking some part of the architecture render Issues about rendering the sprite on the screen
Milestone
v1.3.x

Comments

@dacap
Copy link
Member

dacap commented Sep 13, 2022 •
edited
Loading

A planned effort we have (as an item of #960) is to rewrite the rendering engine to use shaders (SkSL language, skia shaders). This should fix several issues at the same time and can be a progressive effort:

I have a minimal work-in-progress commit to start the refactor, but nothing serious yet.

Some initial work was done with a66c170 and d012bd2 and I'll start a PR to make some progress and indicate the steps to follow.
@dacap dacap added feature Feature request, or something should be improved maintenance performance render Issues about rendering the sprite on the screen refactor complexity This issue needs some refactor / modifying several files / rethinking some part of the architecture gpu labels Sep 13, 2022
@dacap dacap added this to the v1.3 milestone Sep 13, 2022
@dacap dacap self-assigned this Sep 13, 2022
@dacap dacap mentioned this issue Sep 13, 2022
Open
5 tasks
@dacap dacap assigned dacap and unassigned dacap Sep 15, 2022
@dacap dacap added the wip label Sep 16, 2022
@dacap dacap mentioned this issue Sep 16, 2022
Merged
@dacap dacap linked a pull request Sep 16, 2022 that will close this issue
Initial work for a new shader-based renderer #3523
Merged
@dacap dacap mentioned this issue Sep 23, 2022
Open
@dacap dacap removed the wip label Oct 6, 2022
@dacap dacap mentioned this issue Mar 18, 2023
Closed
dacap added a commit to dacap/aseprite that referenced this issue Apr 7, 2023
@dacap
Merge branch 'gpu' (aseprite#3516, aseprite#3523)
4f80008 
An initial implementation (not yet ready for production) of the
ShaderRenderer to use SkSL shaders to convert indexed -> RGB, and draw
SkImages directly on SkCanvases (this will enable future GPU
acceleration).
@gui-marc gui-marc mentioned this issue Apr 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dacap dacap

Labels
feature Feature request, or something should be improved gpu maintenance performance refactor complexity This issue needs some refactor / modifying several files / rethinking some part of the architecture render Issues about rendering the sprite on the screen
Projects
None yet
Milestone
v1.3.x
Development

Successfully merging a pull request may close this issue.

Initial work for a new shader-based renderer dacap/aseprite
1 participant
@dacap