Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.md to faster clone, and build instructions skia for python3 #2090

Closed
wants to merge 5 commits into from

Conversation

HardPlant
Copy link

  • added --depth 1 args to clone skia dependancy
  • added instruction for python3 users

@HardPlant HardPlant requested a review from dacap as a code owner June 17, 2019 10:46
@HardPlant HardPlant changed the title Update INSTALL.md to faster clone, and build skia for python3 Update INSTALL.md to faster clone, and build instructions skia for python3 Jun 17, 2019
@dacap
Copy link
Member

dacap commented May 25, 2020

These instructions are now for skia repo, anyway I would like to keep the instructions as close to the official instructions (from Google) as possible.

@dacap dacap closed this May 25, 2020
@dacap
Copy link
Member

dacap commented May 25, 2020

I saw that the official Skia instructions now use python2 explicitly, I'll add an issue to add python2 to that repository, but it's something I've to test yet on all platforms, so not sure if it does work or is really needed (seeing that just python does the job in the workflows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants