Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save dynamics options between sessions (fix #3933) #3986

Merged
merged 1 commit into from Aug 14, 2023

Conversation

Gasparoken
Copy link
Member

First approach and observations:

Selected DitheringMatrix preference is saved as an integer (selected index in the comboBox).

At the moment, dynamic options are configured:

  • maxSize/Angle == max size/angle of the active tool
  • The rest of the dynamic options are shared between all the tools.

Suggestions:

  • Make all dynamic options global, or
  • Make sets of dynamic options for each tool.

Starting a new sprite with dynamic options active + no warning about this can be confusing until the artist realizes dynamic options are active. Alternatives:

  • Warn the artist that dynamic options are active.
  • Start new sessions with Static sensors on Size/Angle/Gradient.

Suggestion: add "Dynamics ON/OFF" CheckBox.

fix #3933

@Gasparoken Gasparoken assigned Gasparoken and dacap and unassigned Gasparoken Jul 28, 2023
@Gasparoken Gasparoken marked this pull request as ready for review August 9, 2023 19:55
@Gasparoken Gasparoken requested a review from dacap as a code owner August 9, 2023 19:55
@dacap dacap merged commit 2cc15cd into aseprite:main Aug 14, 2023
7 checks passed
@dacap
Copy link
Member

dacap commented Aug 14, 2023

I saw that the Dynamics configuration is in but I'm not sure if the "Same in All Tools" makes a difference:

image

@Gasparoken
Copy link
Member Author

At the moment, the Dynamics options works as "Same in all Tools".

I see that the settings for other tools work independently, and Ink's "Same in all Tools" does not affect them. I mention this to establish that the Ink's "Same in all tools" should not be related to the "Dynamics" options.

I think it would be great to memorize the dynamics options per tool. And implement an additional "Same in all Tools" flag in the 'Dynamics' options window. I'm going to create an issue for this new feature.

@dacap
Copy link
Member

dacap commented Aug 15, 2023

And implement an additional "Same in all Tools" flag in the 'Dynamics' options window. I'm going to create an issue for this new feature.

that’s right 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save pen pressure between sessions
2 participants