Prevent crash when moving pixels from tilemap with inexistent tiles #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from a tilemap with inexistent tiles (fix aseprite#4071)
Gasparoken
reviewed
Oct 12, 2023
Gasparoken
approved these changes
Oct 12, 2023
Gasparoken
approved these changes
Oct 12, 2023
|
I'll merge this as it is, as Gaspar said for one line continue/break statements it's preferred to avoid braces. |
|
Alright...maybe I should have kept the comment?...since this was a copy of the same if block in line 661... |
Actually I think there is still a bug with this fix: the auto mode start failing when we paint in non-existent tiles (it does nothing). That is the expected behavior in Manual mode, as the comment in line 662 says (which is a TODO for a possible future Manual mode filling empty tiles), but for Auto it should paint. I'll create a new issue in a couple of weeks about this. |
martincapello
deleted the
fix-crash-moving-selection-tilemap-inexistent-tiles
branch
This was referenced Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent crash when in Auto or Stack mode the user tries to move pixels from a tilemap with inexistent tiles.
Fix #4071