Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strings typo #4156

Merged
merged 2 commits into from Nov 20, 2023
Merged

Fix strings typo #4156

merged 2 commits into from Nov 20, 2023

Conversation

TakWolf
Copy link
Contributor

@TakWolf TakWolf commented Nov 20, 2023

Fix some strings typo


I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing

@TakWolf TakWolf requested a review from dacap as a code owner November 20, 2023 06:53
@TakWolf TakWolf changed the title Fix strings spelling typo Fix strings typo Nov 20, 2023
@dacap dacap self-assigned this Nov 20, 2023
@dacap dacap added this to the v1.3 milestone Nov 20, 2023
@dacap
Copy link
Member

dacap commented Nov 20, 2023

Thanks @TakWolf! I think we can merge first two commits, but I see some problems with the third one ( 73dc522 ), because we need to specify two && in some cases, e.g.

With the patch:

image

Original:

image

Other regressions introduced:

image
image
image

@TakWolf
Copy link
Contributor Author

TakWolf commented Nov 20, 2023

I withdrew the third commit.
But I don't understand the principle.
What is the uniqueness of these four places?There are also cases where a single ‘&’ is used elsewhere.

@dacap
Copy link
Member

dacap commented Nov 20, 2023

What is the uniqueness of these four places?

In these places the & has a special meaning (to indicate which character acts like a shortcut/mnemonic to quickly access the action) and that character will be underscored (so a special text drawing function is used, one that processes the & chars in a special way). I'm not sure if it's working on all those places (e.g. in "Guides && Slices" shouldn't be the case), but probably it's something to fix in the future as it's low priority.

@dacap dacap merged commit 55e65a1 into aseprite:main Nov 20, 2023
14 checks passed
@TakWolf TakWolf deleted the strings_typo branch November 21, 2023 05:37
@dacap dacap modified the milestones: v1.3.0, v1.3-rc9 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants