Fx Alt+T -> Alt+V instantly crashes Aseprite without warning (fix #4221) #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ui/menu.cpp
Outdated
Comment on lines
648
to
656
| MenuItem* child_with_submenu_opened = nullptr; | ||
| findChildWithSubmenuOpened(menu, child_with_submenu_opened); | ||
| if (child_with_submenu_opened && | ||
| child_with_submenu_opened->inBar() && | ||
| this->type() == kMenuBarWidget && | ||
| msg->modifiers() == kKeyAltModifier) { | ||
| cancelMenuLoop(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I've been testing the fix and it works great. The only thing I'm not sure about is this piece of code, which I couldn't figure out how to make this if condition true. I also tested the fix without this code and it seems to work as well. So I would love to know what I am missing here.
There was a problem hiding this comment.
You're right! Thank you!
Gasparoken
force-pushed
the
crash-alt
branch
from
13ae68b
to
e19c209
Compare
martincapello
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First approach.
fix #4221