New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New text tool #4383
Draft
dacap
wants to merge
7
commits into
aseprite:beta
Choose a base branch
from
dacap:new-text-tool
base: beta
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
New text tool #4383
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
97574e1
New ui::FocusMessage with oldFocus/newFocus fields
dacap 6d150a3
New font selector (fix #4363)
dacap a086348
Use the most regular/normal typeface style for preview purposes
dacap ec238b6
Add Bold/Italic buttons to select a font
dacap ae0873a
Fix bug ignoring bold/italic after we click another font name
dacap 799d663
Fix required bounds for text using shaped text w/the font of each tex…
dacap 3456fc2
Fix FontInfo tests
dacap File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
<!-- Aseprite --> | ||
<!-- Copyright (C) 2024 by Igara Studio S.A. --> | ||
<!-- Copyright (C) 2015-2017 by David Capello --> | ||
<gui> | ||
<vbox id="font_popup"> | ||
<search id="search" magnet="true" /> | ||
<view id="view" expansive="true" /> | ||
<hbox> | ||
<boxfiller /> | ||
<button id="load_font" text="@.load" magnet="true" minwidth="80" /> | ||
<button id="load_font" text="@.load" minwidth="80" /> | ||
</hbox> | ||
</vbox> | ||
</gui> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method 'fontInfo' can be made static [readability-convert-member-functions-to-static]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a bug in clang-tidy.