Fix don't paint transparent color via Eraser tool in Background layers (fix #4370) #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix aseprite#4370) Before this fix, when working with sprites that included a background layer and using the Eraser tool, drawing transparent pixels was allowed if the secondary color was transparent + right click (i.e. eraser in replace mode "Primary color ->to-> Secondary"). Original issue aseprite#4370 description: "Downloaded PNG in RGB mode fails to support transparency: erase uses secondary color and export PNG replaces transparent color with black"
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
The fix works as intended. I'm just not sure if it works as expected. Because the paint bucket behaves different when trying to paint a background layer with a color that has an alpha < 255. For instance, with this fix, a full transparent black will be painted as black by the eraser but as nothing (no color is painted) by the paint bucket.
|
@martincapello and I verified the correct behavior of Paint Bucket Tool (there was only one confusion about the ink used during testing). |
martincapello
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue #4370 description:
"Downloaded PNG in RGB mode fails to support transparency: erase uses secondary color and export PNG replaces transparent color with black"
fix #4370