Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward compatible GetIdentityV2 #83

Merged
merged 1 commit into from
May 3, 2023
Merged

Forward compatible GetIdentityV2 #83

merged 1 commit into from
May 3, 2023

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented May 3, 2023

This PR makes GetIdentityV2 work both with and without internal IDs.
If GetRelation returns object IDs, they are used to look up the returned objects.
Otherwise, objects are looked up by "<type>:<key>".

@ronenh ronenh requested a review from carabasdaniel May 3, 2023 22:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4877105013

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 38.209%
Changes Missing Coverage Covered Lines Changed/Added Lines %
directory/identity.go 3 5 60.0%
Totals Coverage Status
Change from base Build 4834939332: 0.02%
Covered Lines: 1186
Relevant Lines: 3104
💛 - Coveralls

@ronenh ronenh merged commit ce6518b into main May 3, 2023
@ronenh ronenh deleted the get-relation-with-objects branch May 3, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoland apoland apoland approved these changes

@carabasdaniel carabasdaniel Awaiting requested review from carabasdaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ronenh @coveralls @apoland