Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update topaz API and directory configuration #91

Merged
merged 17 commits into from
Jul 10, 2023
Merged

Update topaz API and directory configuration #91

merged 17 commits into from
Jul 10, 2023

Conversation

carabasdaniel
Copy link
Contributor

@carabasdaniel carabasdaniel commented Jun 9, 2023 •
edited

Closes #92

@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited

Pull Request Test Coverage Report for Build 5484876469

  • 247 of 356 (69.38%) changed or added relevant lines in 9 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.7%) to 36.615%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/topazd/topaz_run.go 0 1 0.0%
pkg/cc/config/topaz_config.go 3 7 42.86%
pkg/testing/client.go 3 10 30.0%
pkg/cc/config/config.go 57 67 85.07%
pkg/app/topaz/wire_gen.go 15 27 55.56%
pkg/app/authorizer.go 160 235 68.09%
Files with Coverage Reduction New Missed Lines %
pkg/app/authorizer.go 2 67.35%
Totals Coverage Status
Change from base Build 5448076825: -1.7%
Covered Lines: 1101
Relevant Lines: 3007
💛 - Coveralls

@carabasdaniel carabasdaniel requested a review from gertd June 9, 2023 13:30
@gertd
Copy link
Member

gertd commented Jun 12, 2023

We should hold this change until we rework the service hosting to solve the race condition starting topaz as that most likely will result in a configuration change, as topaz needs to be able to configure all network endpoints and services associated with the endpoints.

@carabasdaniel carabasdaniel force-pushed the directory_config branch 6 times, most recently from 50fb1ed to b8dce2f Compare June 21, 2023 07:00
@carabasdaniel carabasdaniel force-pushed the directory_config branch 4 times, most recently from 8269625 to e0d7fc4 Compare June 26, 2023 11:20
@carabasdaniel carabasdaniel marked this pull request as ready for review June 27, 2023 12:51
ronenh
ronenh reviewed Jun 27, 2023
View reviewed changes
pkg/app/authorizer.go Outdated Show resolved Hide resolved
pkg/app/authorizer.go Outdated Show resolved Hide resolved
pkg/app/authorizer.go Outdated Show resolved Hide resolved
pkg/builder/service_factory.go Outdated Show resolved Hide resolved
@carabasdaniel carabasdaniel force-pushed the directory_config branch 2 times, most recently from 8225261 to f86b14c Compare June 28, 2023 16:15
@carabasdaniel carabasdaniel mentioned this pull request Jun 29, 2023
Closed
ronenh
ronenh reviewed Jun 29, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@carabasdaniel carabasdaniel requested a review from ronenh July 3, 2023 08:23
ronenh
ronenh reviewed Jul 5, 2023
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
pkg/app/authorizer.go Outdated Show resolved Hide resolved
@carabasdaniel carabasdaniel changed the title Update directory configuration Update topaz API and directory configuration Jul 10, 2023
@carabasdaniel carabasdaniel merged commit 6bb64a6 into main Jul 10, 2023
5 checks passed
@carabasdaniel carabasdaniel deleted the directory_config branch July 10, 2023 09:02
@carabasdaniel carabasdaniel mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh ronenh left review comments

@gertd gertd gertd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update directory configuration
3 participants
@carabasdaniel @gertd @ronenh