Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send client_id in logout request #236

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Send client_id in logout request #236

merged 4 commits into from
Oct 2, 2023

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Sep 21, 2023 •
edited
Loading

Purpose

This PR updates the getSignOutURL method to send client_id query parameter instead of id_token_hint by default. This PR also introduces a new optional config sendIdTokenInLogoutRequest. If this is set to true, logout request will contain id_token_hint parameter instead of client_id

Related issue

Achintha444
Achintha444 previously approved these changes Sep 25, 2023
View reviewed changes
@Yasasr1 Yasasr1 merged commit 595750c into asgardeo:master Oct 2, 2023
1 check passed
This was referenced Oct 2, 2023
Merged
Merged
Merged
@Yasasr1 Yasasr1 mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Achintha444 Achintha444 Achintha444 approved these changes

@brionmario brionmario Awaiting requested review from brionmario brionmario is a code owner

@NipuniBhagya NipuniBhagya Awaiting requested review from NipuniBhagya NipuniBhagya is a code owner

@inthirakumaaran inthirakumaaran Awaiting requested review from inthirakumaaran inthirakumaaran is a code owner

@jeradrutnam jeradrutnam Awaiting requested review from jeradrutnam jeradrutnam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yasasr1 @Achintha444