Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spa-sdk to v1.0.1 and fix webpack errors #179

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

DonOmalVindula
Copy link
Contributor

@DonOmalVindula DonOmalVindula commented Feb 27, 2023

Purpose

$subject
This will update the spa sdk to v1.0.1 and will fix the webpack errors when using npm install on the sample react app. It also removes/replaces some of the deprecated libraries being used

Goals

  • Update SPA SDK to v1.0.1 which includes some fixes for local storage based silent sign in approach
  • Update webpack config to remove deprecating options
  • Remove eslint-loader dependency from React SDK as it is deprcated and not being used
  • Removed react-json-view in favour of @textea/json-viewer as the previous package does not support react 18 [1].
  • Update release.yml to remove node_modules and build artifacts from asgardeo-choreo-react-express sample app release workflow

[1] - mac-s-g/react-json-view#441

Related issue

@DonOmalVindula DonOmalVindula merged commit f6bb12f into asgardeo:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants