Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous function calculations are inconsistent with module calculations #625

Closed
zachdaniel opened this issue Jun 15, 2023 · 1 comment
Closed

Anonymous function calculations are inconsistent with module calculations #625

zachdaniel opened this issue Jun 15, 2023 · 1 comment
Labels
bug Something isn't working
Milestone
Ash 3.0

Comments

@zachdaniel
Copy link
Contributor

At the moment, module calculations using calculate/3 take a list of records, and return a list of results. However, if you use an anonymous function, you take a single record and return a single result. This is confusing.

We should consider changing this behavior in 3.0.
@zachdaniel zachdaniel added bug Something isn't working needs review and removed needs review labels Jun 15, 2023
@jimsynz jimsynz added this to the Ash 3.0 milestone Jul 11, 2023
rishflab pushed a commit to rishflab/ash that referenced this issue Aug 3, 2023
@MarijnS95
Remove "drop" mention from create_* docs when the result doesn't im…
550182e 
…plement `Drop` (ash-project#625)

Ash doesn't implement `Drop` intentionally, to not be too opinionated
about holding (heap) references to their parent objects
(`Device`->`Instance`->`Entry`) and ensuring they are destroyed in the
right order.  As such, reword the `create` documentation for `Instance`
and `Device` to mention their respective `destroy_*` function instead of
referring to them as being "droppable".

Note that `Entry` is droppable as it does not have a Vulkan `destroy`
function _and_ the dynamically loaded library (behind the "loaded"
feature) is kept alive only for the lifetime of `Entry`.
@zachdaniel
Copy link
Contributor Author

This is complete in the 3.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Ash 3.0
Status: Done
Milestone
Ash 3.0
Development

No branches or pull requests
2 participants
@jimsynz @zachdaniel