Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Correct documentation for Entry functions and related crate features #545

Merged
merged 2 commits into from
Jan 5, 2022
Merged

README: Correct documentation for Entry functions and related crate features #545

merged 2 commits into from
Jan 5, 2022

Conversation

hoj-senna
Copy link
Contributor

Change Entry::new to Entry::linked in accordance with the changelog for ash 0.35.0.

@hoj-senna
Update README.md
60307f8 
Change Entry::new to Entry::linked in accordance with the changelog for ash 0.35.0.
Ralith
Ralith reviewed Jan 5, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@hoj-senna
Update README.md
7f14ae6 
loaded/linked feature: correctly identify default, adjust order
Ralith
Ralith approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ralith Ralith merged commit fdaafe7 into ash-rs:master Jan 5, 2022
@MarijnS95
Copy link
Collaborator

Whoops, looks like a rebase-merge again 😱

Also, I'd appreciate a bit more descriptive titles than "Update README.md" 😟

@Ralith
Copy link
Collaborator

Ralith commented Jan 5, 2022

🤦

@MarijnS95 MarijnS95 changed the title Update README.md README: Correct documentation for Entry functions and related crate features Jan 11, 2022
MarijnS95 added a commit that referenced this pull request Jan 11, 2022
@MarijnS95
changelog: Add entries for recent PRs #545, #534, #553, #551, #549, #554
df8cf1f 


And drop the deprecated =/- markdown syntax from our readme: this is
analogous to #/## for a h1/h2 header, instead of defining a title and
(usually smaller font) subtitle or description.
MarijnS95 added a commit that referenced this pull request Jan 17, 2022
@MarijnS95
changelog: Add entries for recent PRs #545, #534, #553, #551, #549, #554
80b95e6 


And drop the deprecated =/- markdown syntax from our readme: this is
analogous to #/## for a h1/h2 header, instead of defining a title and
(usually smaller font) subtitle or description.
MarijnS95 added a commit that referenced this pull request Jan 17, 2022
@MarijnS95
changelog: Add entries for recent PRs #545, #534, #553, #551, #549, #554
255ee88 


And drop the deprecated =/- markdown syntax from our readme: this is
analogous to #/## for a h1/h2 header, instead of defining a title and
(usually smaller font) subtitle or description.
MarijnS95 added a commit that referenced this pull request Jan 17, 2022
@MarijnS95
changelog: Add entries for recent PRs #545, #534, #553, #551, #549 (#555
a28a667 
)

And drop the deprecated =/- markdown syntax from our readme: this is
analogous to #/## for a h1/h2 header, instead of defining a title and
(usually smaller font) subtitle or description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hoj-senna @MarijnS95 @Ralith