generator: Handle <command> via vk-parse types and nom
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the upcoming `api` attribute in `vk.xml` commands also need to be processed through `vk-parse` which has support for all the new attributes, while `vkxml` is deprecated and completely untouched for years. This conversion unfortunately requires whipping up yet another quick-and-dirty `nom` parser of a specific subset of C used in `vk.xml` to describe parameter signatures. This PR shows that conversion is complete and provides no accidental semantic differences. Also update `vk-parse` to `0.9` which contains a new `code` field on `CommandParam` (`<param>` element) to be able to inspect the code signature of individual parameters rather than parsing them out of (and matching them back to `vk-parse`'s `params` array!) the `<command>` / `CommandDefinition` as a whole: krolli/vk-parse#25 (comment) krolli/vk-parse@615ffb6
Ralith
approved these changes
Mar 21, 2023
MarijnS95
added a commit
that referenced
this pull request
Apr 2, 2023
For the upcoming `api` attribute in `vk.xml` commands also need to be processed through `vk-parse` which has support for all the new attributes, while `vkxml` is deprecated and completely untouched for years. This conversion unfortunately requires whipping up yet another quick-and-dirty `nom` parser of a specific subset of C used in `vk.xml` to describe parameter signatures. This PR shows that conversion is complete and provides no accidental semantic differences. Also update `vk-parse` to `0.9` which contains a new `code` field on `CommandParam` (`<param>` element) to be able to inspect the code signature of individual parameters rather than parsing them out of (and matching them back to `vk-parse`'s `params` array!) the `<command>` / `CommandDefinition` as a whole: krolli/vk-parse#25 (comment) krolli/vk-parse@615ffb6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the upcoming
apiattribute invk.xmlcommands also need to be processed throughvk-parsewhich has support for all the new attributes, whilevkxmlis deprecated and completely untouched for years. This conversion unfortunately requires whipping up yet another quick-and-dirtynomparser of a specific subset of C used invk.xmlto describe parameter signatures. This PR shows that conversion is complete and provides no accidental semantic differences.Also update
vk-parseto0.9which contains a newcodefield onCommandParam(<param>element) to be able to inspect the code signature of individual parameters rather than parsing them out of (and matching them back tovk-parse'sparamsarray!) the<command>/CommandDefinitionas a whole:krolli/vk-parse#25 (comment)
krolli/vk-parse@615ffb6