generator: Emit new c"" CStr literals
#848
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
cstr-literal
branch
5 times, most recently
from
f6949e5
to
e7ee21c
Compare
|
C-string literals have now landed in Rust 1.77. |
MarijnS95
force-pushed
the
cstr-literal
branch
2 times, most recently
from
3442ad4
to
1b9d5be
Compare
These will land in Rust 1.76 and automatically append a `\0` terminator in the compiler without having to have a checked or `unsafe`-unchecked constructor on `CStr`. Hacking in an invalid `\0` anywhere in the string is disallowed with a compiler error. Note that `proc-macro`, and by extension `proc-macro2` only has support for parsing this literal, but not for emitting it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
will land in Rust 1.76have landed in Rust 1.77 just now and automatically append a\0terminator in the compiler without having to have a checked orunsafe-unchecked constructor onCStr.Hacking in an invalid
\0anywhere in the string is disallowed with a compiler error.Note that
proc-macro, and by extensionproc-macro2only has support for parsing this literal, but not for emitting it yet.