Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[taichi] Fix missing volume render test #173

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

erizmr
Copy link
Contributor

@erizmr erizmr commented Mar 21, 2023

Fix missing volume_render_test.py and update the deprecated annotation.

@erizmr
Copy link
Contributor Author

erizmr commented Mar 21, 2023

Hi @ashawkey , it will be great appreciated if you can help review. Thanks!

@ashawkey ashawkey merged commit 3fac34b into ashawkey:main Mar 21, 2023
@ashawkey
Copy link
Owner

Thanks!

@r530044129
Copy link

image
hi, I've updated this requests, but there is still some error.
ModuleNotFoundError: No module named '_freqencoder'
Do you have any thoughts about this?

@erizmr
Copy link
Contributor Author

erizmr commented Mar 23, 2023

Hi @r530044129 , thanks for reporting this. Please refer to the fix PR #178.

@r530044129
Copy link

r530044129 commented Mar 23, 2023

thanks, it's work. I get the validation pngs.
But when i finish training, i want to export the obj mesh, there is another problem

'python main.py --workspace rifle_01 -O --test --save_mesh'
this the the command that i have used

It's seems that there is no mesh or somehing?
image

@erizmr
Copy link
Contributor Author

erizmr commented Mar 23, 2023

Hi @r530044129 , happy to hear that it works. The save_mesh has not been tested for the Taichi backend. According to the log info you provided, I think there are internal variables name mismatches between Taichi encoder and post-processing pipeline. I would like to file an issue and try to make it compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants