Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid similar colour/pattern combinations #5

Open
ashiguruma opened this issue Sep 2, 2016 · 0 comments
Open

Avoid similar colour/pattern combinations #5

ashiguruma opened this issue Sep 2, 2016 · 0 comments
Assignees
@ashiguruma
Labels
enhancement

Comments

@ashiguruma
Copy link
Owner

Although the current pattern generation code avoids contiguous patterns it doesn't stop the same pattern being used for similar colours in a chart.

clashing-patterns

A few ways this could be improved include

  • adding more patterns and
  • actively avoiding pattern re-use
  • checking colour similarity when re-using a pattern
@ashiguruma ashiguruma self-assigned this Sep 2, 2016
@ashiguruma ashiguruma added this to the v1.2.0 milestone Sep 28, 2016
ashiguruma added a commit that referenced this issue Sep 29, 2016
@ashiguruma
Ignore deprecated shapes in random selection
078d797 
Deprecated shape names will now be ignored when randomly selecting shapes for patterns.

Updates #5
ashiguruma added a commit that referenced this issue Nov 9, 2016
@ashiguruma
Ignore deprecated shapes in random selection
00dab7e 
Deprecated shape names will now be ignored when randomly selecting shapes for patterns.

Updates #5
@ashiguruma ashiguruma removed this from the v1.2.0 milestone Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashiguruma ashiguruma

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ashiguruma