Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aws-sdk dependency optional #209

Closed
eduardoboucas opened this issue Apr 20, 2021 · 1 comment · Fixed by #210
Closed

Make aws-sdk dependency optional #209

eduardoboucas opened this issue Apr 20, 2021 · 1 comment · Fixed by #210

Comments

@eduardoboucas
Copy link
Contributor

Hi! We use lambda-local in the Netlify CLI to provide a local environment for serverless functions. Unfortunately, having the AWS SDK as a dependency significantly contributes to our package size, despite the fact that we don't interact with it at all.

I understand that this is required by some of your users and we definitely wouldn't want to disrupt that, but I was wondering if you'd consider publishing a second package without this dependency to accommodate folks who don't need the AWS interaction and could benefit from a smaller payload?

If you're okay with this, I'd be happy to put together a PR with a workflow that automates this process, so that having this second package wouldn't mean additional overhead for the project maintainers.

Thanks in advance!

@gpotter2
Copy link
Collaborator

Hi, this sounds great, feel free to provide a PR anytime.

We only include aws-sdk because it is already included on AWS lambdas, but TBF we could just remove the dep entirely and ask people to download it themselves... If you have a better way that's cool too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants