Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWS-SDK dependency #210

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

eduardoboucas
Copy link
Contributor

@eduardoboucas eduardoboucas commented Jun 18, 2021

Following up on #209, this PR removes aws-sdk as a dependency.

As per AWS best practices:

AWS will include the AWS SDK for NodeJS and Python functions (and update the SDK periodically). However, you should bundle your own SDK and pin your functions to a version of the SDK you have tested. — https://aws.amazon.com/blogs/architecture/best-practices-for-developing-on-aws-lambda/

By removing this dependency, we significantly reduce the package size.

I bumped the version to 2.0.0 because this is technically a breaking change.

Let me know if you have any thoughts/questions. Thanks in advance!

Closes #209.

@gpotter2
Copy link
Collaborator

Looking great, thanks for the PR !

@gpotter2 gpotter2 merged commit 189b7d8 into ashiina:develop Jun 19, 2021
@eduardoboucas
Copy link
Contributor Author

Thank you! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make aws-sdk dependency optional
2 participants