Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade and rewrite docker-push integration for actions #215

Closed
jrozner opened this issue Jan 14, 2021 · 1 comment
Closed

Upgrade and rewrite docker-push integration for actions #215

jrozner opened this issue Jan 14, 2021 · 1 comment
Assignees
@jkennedyvz
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code

Comments

@jrozner
Copy link
Member

jrozner commented Jan 14, 2021

A major release of the docker-push action has been released and is incompatible with our current setup. Most specifically the tagging options have changed and we can no longer get the exact tagging behavior we want out of the box. We can either redefine one of the steps for the action to add the correct logic or switch our tagging behavior.
@jrozner jrozner mentioned this issue Jan 14, 2021
Closed
@jkennedyvz jkennedyvz linked a pull request Feb 3, 2021 that will close this issue
Updating to build-push-action-v2.2.2 #243
Closed
@jkennedyvz jkennedyvz self-assigned this Feb 3, 2021
@jkennedyvz jkennedyvz added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Feb 3, 2021
@jkennedyvz
Copy link
Contributor

Closed with #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkennedyvz jkennedyvz

Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating to build-push-action-v2.2.2 ashirt-ops/ashirt-server
2 participants
@jrozner @jkennedyvz