Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JK Build Rework #254

Merged
merged 12 commits into from
Mar 15, 2021
Merged

JK Build Rework #254

merged 12 commits into from
Mar 15, 2021

Conversation

jkennedyvz
Copy link
Contributor

@jkennedyvz jkennedyvz commented Feb 24, 2021

This PR rolls up changes from #213 and #243.

By renaming the production dockerfiles they can be built with a matrix strategy to improve DRY.
The workflow now builds and pushes PR branches with pr-### and sha-xxxxxxx tags. Commits to master will publish images also tagged latest.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@jkennedyvz jkennedyvz marked this pull request as ready for review February 25, 2021 00:12
@jkennedyvz jkennedyvz changed the title Jk container rework JK Build Rework Feb 26, 2021
@jkennedyvz jkennedyvz added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants