Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to build-push-action-v2.2.2 #243

Closed
wants to merge 2 commits into from
Closed

Conversation

jkennedyvz
Copy link
Contributor

A lot of changes were needed to migrate for dependabot/github_actions/docker/build-push-action-v2.2.2

This PR flattens the working changes from that branch.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@jkennedyvz jkennedyvz added enhancement New feature or request dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Feb 3, 2021
@jkennedyvz jkennedyvz linked an issue Feb 3, 2021 that may be closed by this pull request
@jrozner
Copy link
Member

jrozner commented Feb 5, 2021

Is this setup to tag latest from master?

@jkennedyvz
Copy link
Contributor Author

jkennedyvz commented Feb 5, 2021

Is this setup to tag latest from master?

No actually, by default the action used will tag :latest if semver tagging is used https://github.com/crazy-max/ghaction-docker-meta#latest-tag

If we would like each run of this workflow to tag :latest I can add that manually on lines 72,103, and 134.
Alternatively, we could leverage https://github.com/crazy-max/ghaction-docker-meta#tag-match-examples with a regex of "sha-.*" to always produce latest tag as well.

@jkennedyvz jkennedyvz mentioned this pull request Feb 26, 2021
@jkennedyvz
Copy link
Contributor Author

Everything in this PR has been implemented in #254 instead. Leaving this open until #254 is closed for comment reference.

@jkennedyvz
Copy link
Contributor Author

Closing with the merge of #254

@jkennedyvz jkennedyvz closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade and rewrite docker-push integration for actions
2 participants