Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image display/layout in the evidence viewer #5

Closed
jrozner opened this issue Jun 30, 2020 · 3 comments · Fixed by #29
Closed

Fix image display/layout in the evidence viewer #5

jrozner opened this issue Jun 30, 2020 · 3 comments · Fixed by #29

Comments

@jrozner
Copy link
Member

jrozner commented Jun 30, 2020

Currently the layout causes images to not be displayed within the evidence viewer. This seems to be because the size of the window is just too small on 13" macs. This whole UI should change somewhat with the new tagging system (#9) and some layout changes for buttons and action handling (#6, #7, #8).
Screen Shot 2020-06-30 at 10 28 32 AM
Screen Shot 2020-06-30 at 10 29 30 AM

@JoelAtDeluxe
Copy link
Contributor

While we will reclaim some space from the mentioned PRs, I think we may need to do something additional. The prior version (leaving description on the same row as the preview) works well for images, not as well for codeblocks. The current incarnation has the opposite issue.

A couple of possibilities:

  1. Have two views: one for codeblocks, one for images. This is somewhat complicated and messy, but may be worthwhile to have a nice view for each.
  2. Have images (and I suppose codeblocks) have a way to view their content in large form, via a new window (similar to how the front end does things)
  3. Move the preview/description/tags area to the right, in a new column.

We'll probably want to address this after the other issues mentioned above are addressed.

@jrozner
Copy link
Member Author

jrozner commented Jul 2, 2020

Ya, I agree. I think we should wait on this until we get the new tag system implemented and some of the other changes done to this screen so we have a better idea of the amount of space needed. I think 2 and 3 are going to be the better options and maybe we can think through some other options if neither work out well or there is something better.

@JoelAtDeluxe
Copy link
Contributor

First attempt at a better design in PR #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants