-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image display/layout in the evidence viewer #5
Comments
While we will reclaim some space from the mentioned PRs, I think we may need to do something additional. The prior version (leaving description on the same row as the preview) works well for images, not as well for codeblocks. The current incarnation has the opposite issue. A couple of possibilities:
We'll probably want to address this after the other issues mentioned above are addressed. |
Ya, I agree. I think we should wait on this until we get the new tag system implemented and some of the other changes done to this screen so we have a better idea of the amount of space needed. I think 2 and 3 are going to be the better options and maybe we can think through some other options if neither work out well or there is something better. |
First attempt at a better design in PR #29 |
Currently the layout causes images to not be displayed within the evidence viewer. This seems to be because the size of the window is just too small on 13" macs. This whole UI should change somewhat with the new tagging system (#9) and some layout changes for buttons and action handling (#6, #7, #8).
![Screen Shot 2020-06-30 at 10 28 32 AM](https://user-images.githubusercontent.com/26415/86157775-b914fd80-babc-11ea-965e-03c46a71b12b.png)
![Screen Shot 2020-06-30 at 10 29 30 AM](https://user-images.githubusercontent.com/26415/86157789-bd411b00-babc-11ea-8acc-5e34d816b320.png)
The text was updated successfully, but these errors were encountered: