Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] When multiple devices connected issue command to all of them #11

Closed
YuraLaguta opened this issue Aug 12, 2018 · 6 comments

Comments

@YuraLaguta
Copy link

When using adbe and have multiple devices connected an error is thrown,
Would it be appropriate to just send the command to all devices?
here is some small shell script in accepted answer: https://stackoverflow.com/questions/17882474/running-adb-commands-on-all-connected-devices

@ashishb
Copy link
Owner

ashishb commented Aug 13, 2018

That's a good suggestion; the problem is that it is hard to imagine a reasonable outcome in general. For example, if there are two devices connected and someone executes adbe uninstall com.example, and the app is only installed on one of them, the tool has to tell the user explicitly about missing app on one of the device. The outcome becomes even more confusing when the user takes a screenshot or pulls a file from the device. Should the files be prefixed with the serial name of the device? What do you think?

@YuraLaguta
Copy link
Author

YuraLaguta commented Aug 13, 2018

Few options come to mind:
Param -a to execute on all devices, ignore output, for example when I'm uninstalling I just want to make sure it's uninstalled.
Screenshot and pulling might not support this option, unless there is a strong usecase for it
But your idea with device prefix sounds great, when developing on few devices it would be cool to get screenshot from all before uploading them to PR

@ashishb
Copy link
Owner

ashishb commented Aug 13, 2018

That makes sense, so, rather than being a blanket option, this could be enabled only for very specific options. Which options do you think this could be useful for? The uninstall example you provided does not apply to adbe since as of now, it does not have uninstall sub-command.

@ashishb
Copy link
Owner

ashishb commented Aug 18, 2018

I don't think this makes sense in most of the cases. I will close it for now, I can reconsider it at a later point if there is good enough argument to do it.

@ashishb ashishb closed this as completed Aug 18, 2018
@YuraLaguta
Copy link
Author

YuraLaguta commented Aug 18, 2018 via email

@YuraLaguta
Copy link
Author

Animations is what triggered me to write this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants