Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link of datamodule #444

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix broken link of datamodule #444

merged 1 commit into from
Sep 15, 2022

Conversation

cauliyang
Copy link
Contributor

What does this PR do?

Fix broken link: https://pytorch-lightning.readthedocs.io/en/latest/extensions/datamodules.html
Now: https://pytorch-lightning.readthedocs.io/en/latest/data/datamodule.html

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Sure!

@codecov-commenter
Copy link

Codecov Report

Base: 84.81% // Head: 84.81% // No change to project coverage 👍

Coverage data is based on head (601f3c7) compared to base (f6147fa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files           9        9           
  Lines         349      349           
=======================================
  Hits          296      296           
  Misses         53       53           
Impacted Files Coverage Δ
src/datamodules/mnist_datamodule.py 94.73% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@KLOSYX KLOSYX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old url is invalid.

Copy link
Owner

@ashleve ashleve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cauliyang Thank you for the fix!

@ashleve ashleve merged commit c39eb67 into ashleve:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants