Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning + Aim dependency fix in conda environment.yaml and setup.py. #575

Merged
merged 1 commit into from
May 11, 2023

Conversation

tesfaldet
Copy link
Contributor

What does this PR do?

Change conda package dependency "pytorch-lightning" to "lightning" to avoid import errors. Same was done in setup.py. Added aim dependency in conda environment.yaml.

Before submitting

  • [ x ] Did you make sure title is self-explanatory and the description concisely explains the PR?
  • [ x ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ x ] Did you list all the breaking changes introduced by this pull request?
  • [ x ] Did you test your PR locally with pytest command?
  • [ x ] Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

ye

Make sure you had fun coding 🙃

… avoid import errors. Same was done in setup.py. Added aim dependency in conda environment.yaml.
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (8886a13) 83.61% compared to head (8b5ac66) 83.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files          11       11           
  Lines         354      354           
=======================================
  Hits          296      296           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@ashleve ashleve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashleve ashleve merged commit 467a974 into ashleve:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants