Skip to content

Commit

Permalink
Merge pull request #3 from ashokdey/step-4-ci-cd
Browse files Browse the repository at this point in the history
Update in Readme
  • Loading branch information
ashokdey committed Mar 18, 2019
2 parents 3cac426 + c64d7e9 commit ce27ae0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
Binary file added .github/0.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions README.md
Expand Up @@ -5,6 +5,8 @@ The repository contains both the tests using ~~`Mocha`~~<sup>\*</sup> and `Jest`

[![Build Status](https://travis-ci.org/ashokdey/nodejs-unit-testing.svg?branch=step-4-ci-cd)](https://travis-ci.org/ashokdey/nodejs-unit-testing) [![Coverage Status](https://coveralls.io/repos/github/ashokdey/nodejs-unit-testing/badge.svg?branch=step-4-ci-cd)](https://coveralls.io/github/ashokdey/nodejs-unit-testing?branch=step-4-ci-cd)

![Intro Image](.github/0.png)

## Agenda

- SDLC
Expand All @@ -31,3 +33,4 @@ I planned to carry out the workshop in 4 steps. hence you can find 4 extra branc
## Notes

- <sup>\*</sup>Due to lack of time I dropped the idea of Mocha, let's see when I can publish Mocha stuff
- [Link to the slides](https://docs.google.com/presentation/d/1s6HfL4GizW7f09Lq3mcA_k82x45tIV2Rh_MsIOLu0YE/edit?usp=sharing)
2 changes: 1 addition & 1 deletion code/classes/User.test.js
Expand Up @@ -18,7 +18,7 @@ describe('User Class', () => {
john = new User({ firstName, mobile });
});

it('Should not create an user without a name', () => {
it('Should not create an user without a first name', () => {
expect(() => new User({ firstName: '', mobile })).toThrow(ErrorMessages.FirstNameRequired);
});

Expand Down

0 comments on commit ce27ae0

Please sign in to comment.