Add Host NC communication support in Windows with HnsV2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-vm-container-experiment
…w-vm-container-experiment
In case of WebApps the NC goal state gets saved with CNS if the loopback adapter creation is successful. This change fixes the bug where the goal state wasn't getting saved because the condition for WebApps containerType would run into default case and error out.
…Azure#421) * added application insights telemetry package to send metrics and logs to appinsights * moved a function common to both packages acquired a lock before writing to file * added read write lock as per chandan comment. Addressed jaeryn comments * fixed telemetry unit test * defined interface and added appinsights package as vendor to acn * added vendor package.go(appinsights) * dependencies of appinsights * added AI dependencies * updated unit tests * addressed review comments
tamilmani1989
suggested changes
Oct 18, 2019
Azure#417) Support hyper-v and process based containers with cricontainerd (*COW)
ashvindeodhar
pushed a commit
that referenced
this pull request
Jun 13, 2021
…ure#836) * Junguk cho pod controller support (#1) * code layout to support pod controller in npm * filter events if they do not need to handle and clean up business logic * put lock when it needs to access shared resource use namespace/name as key clean up functions * - use pod key instead of uid. - remove unnecessary error check * use namespace prefix in pod namespace. add log messages to know what events happens. * move event logs with more contexts in needsync func * Put returning an error in a right place * Return if the RV of both pod obj are the same. Proactively start cleaning up pod when the pod is deleted. * first version of podController UT * add ipset management in pod controller unit test * Make methods flexible for ipset store and restore operation * clean up functions and variables Co-authored-by: Junguk Cho <jungukcho@microsoft.com> * correct and clean functions and error messages. Return errors from appendNamedPortIpsets function to retry syncPod operation * Check npmPod exists in cleanUpDeletedPod function. Use GetIPSetListFromLabels in syncAddedPod and cleanUpDeletedPod functions. Correct error messages, functions, etc * Clean up podController code. Make podController UT more flexible. * clean up appendNamedPortIpsets to improve readibility * minor update (v1 -> corev1) for consistency * clean up syncPod code to compare last applied states and new pod's states * add validation for casting old pod. correct log message * delete unneeded codes * minor fix: correct comments and removed unneeded variables * add pre-filter codes to avoid unnecessary reconcile process in updatePod event * correct a comment * check workqueue length to validate case where it does not need to reconcile in unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for host NC bidirectional communication with windows HnsV2. This is supported in multitenant scenario only. AllowHostToNCCommunication and AllowNCToHostCommunication flags are used to enable Host to NC and NC to host communication respectively.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: