Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send notifications for each matching rule, not just the first #19

Closed
kennethkalmer opened this issue Aug 24, 2015 · 3 comments
Closed

Comments

@kennethkalmer
Copy link

With the following configuration I expected that we'll only get recoveries published in our main channel and the nitty gritty details in individual rooms we run per service.

  pipelines = [{
    name = ".*"
    stage = ".*"
    state = "failed|broken|fixed"
  },
  {
    name = "some-api"
    stage = ".*"
    state = "all"
    channel = "#some-api"
  },
  # ... More pipelines like *some-api*
  ]

Instead only the first rule got matched and the rest not. If this behaviour is desirable I can take a stab at a PR to get it in.

@ashwanthkumar
Copy link
Owner

cc: @Sriram-R

@jdavisp3
Copy link
Collaborator

👍 to this feature, applying all matching rules would allow much more flexibility.

@jdavisp3
Copy link
Collaborator

We could preserve backwards compatibility by making this an optional feature, or adding a boolean flag, default false, to a rule that says to continue processing other rules even if this one applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants