Add processAllRules option. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -199,6 +220,11 @@ public static Rules fromConfig(Config config) { | |||
| displayMaterialChanges = config.getBoolean("displayMaterialChanges"); | |||
| } | |||
|
|
|||
| boolean processAllRules = false; | |||
| if (config.hasPath("processAllRules")) { | |||
There was a problem hiding this comment.
I hate to say this, but can you please switch to - based convention for the config name? I wanted to do the same for displayMaterialChanges as well. Pretty please!
There was a problem hiding this comment.
Sure, no problem, I will do that.
ashwanthkumar
requested changes
Oct 17, 2016
|
Build failed because of a configuration issue. Fixed that re-triggered it. |
I totally thought I did that but apparently I dreamed it. Added a test in 735a74e. |
ashwanthkumar
approved these changes
Oct 17, 2016
|
Thanks @ashwanthkumar, I will totally update the README and docs, thanks! |
|
Ok, docs and README updated in 0bbc459. |
|
Thanks @jdavisp3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
processAllRulesoption. It is optional and if not specified orFalsethe rules are processed as now. IfTrue, instead of stopping at the first matching rule, all rules are processed and all matching rules will be applied.Fixes #52. Fixes #19.