Remove unused logging parameter. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, nice find. Those keep sneaking in with changes that are ported from Lerna. Fortunately my loglevels patch was eventually applied to Lerna (under someone else's name), so we shouldn't see too many more of them. |
|
I wonder where the call with |
|
The warning itself looks very similar to the root validation in the base |
|
Well... seeing as it's basically dead code now... maybe we can just remove it instead? 👹 |
|
Yeah, there's a lot of similar logging in BootstrapCommand, the only place this method is even used, it's probably safe to remove. |
evocateur
force-pushed
the
fix-logger-warning
branch
from
ab46580
to
3255121
Compare
|
I decided to delete the unused block, it's just cleaner. |
evocateur
changed the title
|
🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not that
hasMatchingDependency()is ever called with logging enabled, but it was bothering me.(Found it while trawling lerna pull requests)