Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused logging parameter. #63

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Remove unused logging parameter. #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/Package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import objectAssign from "object-assign";
import path from "path";
import semver from "semver";
import NpmUtilities from "./NpmUtilities";
import logger from "./logger";

export default class Package {
constructor(pkg, location) {
Expand Down Expand Up @@ -82,10 +81,9 @@ export default class Package {
/**
* Determine if a dependency version satisfies the requirements of this package
* @param {Package} dependency
* @param {Boolean} showWarning
* @returns {Boolean}
*/
hasMatchingDependency(dependency, showWarning = false) {
hasMatchingDependency(dependency) {
const expectedVersion = this.allDependencies[dependency.name];
const actualVersion = dependency.version;

Expand All @@ -98,14 +96,6 @@ export default class Package {
return true;
}

if (showWarning) {
logger.warning(
`Version mismatch inside "${this.name}". ` +
`Depends on "${dependency.name}@${expectedVersion}" ` +
`instead of "${dependency.name}@${actualVersion}".`
);
}

return false;
}

Expand Down