Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language Switcher / 言語切替機能追加 #95

Merged
merged 12 commits into from
Jul 8, 2023
Merged

Conversation

askdkc
Copy link
Owner

@askdkc askdkc commented Jul 7, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jul 7, 2023

PR Summary

  • Installation Guide for Language Switch Feature
    The README.md file now has a new section outlining how to install a feature that allows users to switch languages.

  • New Trait for Language Switching
    We've introduced InstallLanguageSwitcher in BreezejpCommand.php. This piece of code will enable the application to handle language switching functionalities.

  • New Files for Language Switching Commands
    In the Commands directory, we've added a new file called InstallLanguageSwitcher.php which contains instructions that the system will follow when installing the language switcher feature.

  • New Middleware for Localization
    Added a file Localization.php in the stubs/app/Http/Middleware directory. This is a middleware file, which helps manage the flow of processing requests and responses in our system, specifically tailored for localization (supporting multiple languages).

  • Adding Route for Language Switching
    A new web.stub file in the stubs/default/routes directory. This file establishes a new route, providing a way for the application to respond when users want to switch languages.

  • Kernel Configuration Updates
    We've also created Kernel.stub in stubs/app/Http directory. This allows us to update our system's kernel configurations specifically needed for the newly added features.

Please note that the "stub" files mentioned above are template files used as a base for generating new files.

ローカルだと問題ないけど、CI上だと怒られるので削除
 
```bash
 Call to a member function toBeUsed() on array

  at tests/NoDebugCommandLeftTest.php:5
      1▕ <?php
      2▕ 
      3▕ test('globals')
      4▕     ->expect(['dd', 'dump','ray'])
  ➜   5▕     ->not->toBeUsed();
```
@askdkc askdkc merged commit 641e40d into main Jul 8, 2023
13 checks passed
@askdkc askdkc deleted the add-langswitcher branch July 8, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant