Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

CCI Reference Missing #1139

Closed
Jyck opened this issue Sep 20, 2017 · 4 comments
Closed

CCI Reference Missing #1139

Jyck opened this issue Sep 20, 2017 · 4 comments
Labels

Comments

@Jyck
Copy link

Jyck commented Sep 20, 2017

this.requiredHistory = config.tradingAdvisor.historySize;

this.requiredHistory = config.tradingAdvisor.historySize;
change to
this.requiredHistory = this.tradingAdvisor.historySize;

@askmike
Copy link
Owner

askmike commented Sep 20, 2017

Nice find! Can you propose a PR for this (towards the develop branch)? Thanks :)

askmike pushed a commit that referenced this issue Sep 20, 2017
@krieghof
Copy link
Contributor

Can we close this now?

@askmike
Copy link
Owner

askmike commented Sep 20, 2017

This is now fixed in develop, but not in stable yet. Once I release a new version this issue will automatically close :)

@stale
Copy link

stale bot commented Oct 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me.

@stale stale bot added the wontfix label Oct 24, 2018
@stale stale bot closed this as completed Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants