Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Fix log.debug statements #1314

Merged
merged 1 commit into from Nov 19, 2017
Merged

Fix log.debug statements #1314

merged 1 commit into from Nov 19, 2017

Conversation

andyklimczak
Copy link
Contributor

@andyklimczak andyklimczak commented Nov 11, 2017

  • Revert partial code from commit 2c5306e that broke(?) log.debug statements inside strategies
  • Fix small typo
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    log.debug is not logging

  • What is the new behavior (if this is a feature change)?
    fix log.debug

  • Other information:
    log.debug from OOTB strategies are not working on latest develop
    I'm not sure if the message.log change was an intentional change, or an accidental addition

* Fix code from commit `2c5306e12` that broke(?) `log.debug` statements
* Fix small typo
@askmike
Copy link
Owner

askmike commented Nov 19, 2017

I removed this (in a commit for something else - apologies) because it was slowing down backtests (since most strats log a lot and all this data was pushed from the backtester -> parent process -> stdout).

But I see this basically hides all logs from the backtesters (when using the UI or API).

I was thinking the following instead:

  • in the UI add a "debug" tickbox to the backtest screen, this toggles the log level of the backtester (to either log or not).
  • Apply this patch so that if the backtester logs, it should stream up.
  • Add documentation on how to properly set up a "create strategy environment".

What do you think?

@askmike
Copy link
Owner

askmike commented Nov 19, 2017

I am actually applying this already, since it is currently actually a bug. Though the above question still holds.

@askmike askmike merged commit 7da3cf3 into askmike:develop Nov 19, 2017
This was referenced Nov 19, 2017
@andyklimczak andyklimczak deleted the fix-logging branch November 20, 2017 01:07
@andyklimczak
Copy link
Contributor Author

For sure, some type of checkbox makes sense (and even control in the code with something like this.debug = true)

@askmike
Copy link
Owner

askmike commented Nov 20, 2017

How the config behaves in general (especially when using the UI) is grown a bit out of hand, if you are interested in the full discussion please check out #956.

Before the UI there was one config that did everything, now it is split into a few different categories (how you want everything to behave, like database stuff / how you want the UI to behave, like ports and hosts / how you want individual instances to behave, like this feature).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants