This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
docs(supported_exchanges): use check and x symbols #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
patch-2
branch
2 times, most recently
from
fdf196e
to
5471e8c
Compare
levithomason
force-pushed
the
patch-2
branch
from
5471e8c
to
7ca9528
Compare
|
great stuff, thanks. I will check how it renders on the documentation website ASAP. |
|
This looks great :) |
|
I tested this fine locally but it broke on production (=the live website):
EDIT: Nevermind, fixed by forcing UTF8 from the server. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Docs.
What is the current behavior?
I think the
Vin the table is attempting to symbolize a check mark, meaning "supported", while theXis "not supported". However, this is not clear.What is the new behavior (if this is a feature change)?
I've replaced the
Vwith HTML checkmark entities and theXwith HTML multiplication entities. These render nicely in markdown and in HTML.Other information:
I originally started this PR to add the missing exchanges to the import list but I see that has already been done. The doc site needs to be updated, though.