This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
Refresh & log updated portfolio balance so that advice & trading is not based on old data #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some users would prefer the cex.io portfolio balance should be refreshed periodically with more current BTC balance (as a result of BTC withdraw, deposit, mining new coin with the GHS, etc.) this commit will affect all exchanges, not just cex.io refresh period is 20 minutes
bugfix for gekko having a stale internal state which doesn't match the actual balance in portfolio
|
Thanks, unfortunately I am offline this weekend, but will def take a look as soon as I get back. |
|
I've tested the code in #67 & left it running for a couple days now and had no problems, so I'm signing off on this feature as "the code has actually been tested & it seems stable" and I also don't expect to feel the need for any further changes to this initial code for the refresh-balance branch. it was suggested on #65 (commit fa9f8f2 was accidentally "logging only" code ... wrote that before I realized the balance itself wasn't being refreshed) that the interval should be configurable. I agree, it should probably be configurable but I don't have time to implement it this weekend. |
askmike
added a commit
that referenced
this pull request
Dec 21, 2013
Refresh & log updated portfolio balance so that advice & trading is not based on old data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time a "refresh-balance" branch was created on my own repository unlike #65 and #66 which were NOT properly insulated from any work I was doing on my own fork unrelated to this patch for keeping the portfolio state more consistent with realtime balance on the exchanges.