Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: searchdata not loading properly on serve #712

Merged
merged 1 commit into from
May 3, 2024

Conversation

raiindev
Copy link
Contributor

@raiindev raiindev commented May 3, 2024

Description

The scope of this PR is to fix an issue related to the search box not working properly when npm run serve is launched.

Main changes

  • Add optional chaining to check if searchData is undefined

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 9:50am

@raiindev raiindev requested a review from micheleriva May 3, 2024 09:50
@micheleriva micheleriva merged commit c69fb54 into main May 3, 2024
3 checks passed
@micheleriva micheleriva deleted the fix/docusaurus-serve-searchbox-not-working branch May 3, 2024 16:25
@ilteoood
Copy link
Contributor

ilteoood commented May 7, 2024

@micheleriva in order to fix the issue on formatjs, I think it would be better to release this

@micheleriva
Copy link
Member

@ilteoood releasing in 30min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants