finds the best run for a given experiment. #75
Conversation
| /// <param name="experimentId"></param> | ||
| /// <param name="metricName"></param> | ||
| /// <returns></returns> | ||
| IRun GetBestRun(Guid experimentId, string metricName); |
There was a problem hiding this comment.
Shouldn't this be a part of IExperiment?
It is not a lifecycle method.
There was a problem hiding this comment.
@shanranm that's correct, another way is for it to live on the Experiment depending on if you prefer light entities or a more DTO style entity. I think in this case it belongs on the lifecycle context mostly because this will be a method one calls at the end of a training run to determine if this run is good enough to bother uploading an artifact/model. If it's not better than anything previously we may want to save storage space and skip the upload step. I recognize that it's a matter of taste though :)
There was a problem hiding this comment.
If we are going with lighter entities then this looks good! 👍
There was a problem hiding this comment.
Great @AnoojNair, glad you get use of the underlying methods :)
Left a minor comment.
| /// <param name="experimentId"></param> | ||
| /// <param name="metricName"></param> | ||
| /// <returns></returns> | ||
| IRun GetBestRun(Guid experimentId, string metricName); |
There was a problem hiding this comment.
@shanranm that's correct, another way is for it to live on the Experiment depending on if you prefer light entities or a more DTO style entity. I think in this case it belongs on the lifecycle context mostly because this will be a method one calls at the end of a training run to determine if this run is good enough to bother uploading an artifact/model. If it's not better than anything previously we may want to save storage space and skip the upload step. I recognize that it's a matter of taste though :)
…sue-15-find-best-run
Resolves
Fixes #15
Description
Finds the best run for a experiment based on a metric like "Accuracy".
Thank you @aslotte @dcostea for adding those functions as they do all the heavy lifting. I created a new PR with a new branch in my fork so that the commit history is a bit more cleaner, had a few merge conflicts on the old branch. I hope that's ok. Not sure how to remove the #57
Also. I am unable to add dan to this PR. Alex can you please add dan too.