Remove all usage of dynamic_cast<> #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the nodes already hold E57 type information, so we don't need to rely on RTTI. dynamic_cast<> is much slower (especially on MSVC) than custom simple type checks as it must be much more generic. Moreover, we already have those checks in place so usage of dynamic_cast<> is redundant.
* implicit conversions * unused variable
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This removes usage of dynamic_cast from the library.
As all the nodes already hold E57 type information, we don't need to rely on RTTI. dynamic_cast<> is much slower (especially on MSVC) than custom simple type checks as it must be much more generic. Moreover, there are already those checks in place so usage of dynamic_cast<> is redundant.
This also fixes a couple of warnings reported when compiling with Xcode.
I have formatted the changes with the new
.clang-formatstyle.Cheers,
Jiri
Jiri Hörner
Software Development Engineer, Vuforia
jhoerner@ptc.com
vuforia.com
Parametric Technology Gesellschaft m.b.H., Operngasse 17-21, 1040 Wien, Austria. Firmensitz: Wien, FN: 111171 m, Firmenbuchgericht: Handelsgericht Wien.
The information contained in this email transmission is confidential and may be privileged. If you are not the intended recipient, any use, dissemination, distribution, publication, or copying of the information contained in this email is strictly prohibited. If you have received this email in error, please immediately notify me by calling the above number and delete the email from your system. Thank you for your co-operation.
Copyright © 2020 PTC Inc. and/or all its affiliates or subsidiaries. All rights reserved