Templatize E57Simple to support double coordinates #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The E57Format lib is overloaded to work with several coordinate types, yet the current E57Simple API only supports float coordinates.
Making the E57Simple
Data3DPointsData
struct a template enables the use of different types, such as double.In order to keep the current behavior of the API, the default float template was typedefined using the previous
Data3DPointsData
name.A new double version
Data3DPointsData_d
was also typedefined so that it can be used directly as well.The intent behind this change is that the last official release of the E57Simple API was using double coordinates, and there are still some use-cases where this level of precision is needed.
This is especially the case when working on large scale scenes - such as we do here at Trimble - and this feature should provide more retro-compatibility to the API.
Regards,
Grégoire
Grégoire Jacquemin | Trimble
Software Development Engineer