Fix cpr_nl invalid values/underflow panic #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpr_nl was returning 0 in some cases, which could lead to panics. This
change switches cpr_nl from a trigonometry-based implementation
to (essentially) a table lookup.
I added a couple unit tests, and a criterion benchmark for cpr_nl to
validate the table-based speedup.
On my machine this version is, in the worst case situation, 40%
faster. In the best case it's 89% faster.
```
cpr_nl_high_lat time: [10.764 ns 10.795 ns 10.830 ns]
change: [-40.716% -39.922% -39.255%] (p = 0.00 < 0.05)
Performance has improved.
cpr_nl_low_lat time: [2.2473 ns 2.2617 ns 2.2767 ns]
change: [-89.576% -89.479% -89.386%] (p = 0.00 < 0.05)
Performance has improved.
```
Fixes issue asmarques#3.
wiseman
force-pushed
the
cpr_underflow
branch
from
88f2936
to
0e24334
Compare
|
Thanks. Even with fuzzing it is difficult to catch all the corner cases. The lookup table also seems like a much more robust solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched
cpr_nlto a table lookup, fixing the problem of it returning an invalid value leading to a panic. It's also considerably faster. This fixes issue #3.