Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#69] Upgrade Opine to support Deno 1.4.0 and std 0.69.0 #70

Merged
merged 7 commits into from
Sep 17, 2020

Conversation

asos-craigmorten
Copy link
Collaborator

@asos-craigmorten asos-craigmorten commented Sep 14, 2020

Issue

#69

Details

Upgrade Opine to support Deno 1.4.0 and std 0.69.0.

This requires a number of dependency updates to get us over the line - if you are able to help out by getting one of the below upgraded then please comment in this PR. Your help is much appreciated!

Core module dependencies:

Tests:

Examples:

CheckList

  • PR starts with [#ISSUE_ID].
  • Has been tested (where required) before merge to main.

@github-actions
Copy link

github-actions bot commented Sep 14, 2020

Benchmark results

PR to merge feat/deno-1.4.0-std-0.69.0 fd3eb3d -> main
1 middleware
	8084.10 RPS

5 middleware
	8138.05 RPS

10 middleware
	8029.60 RPS

15 middleware
	8104.78 RPS

20 middleware
	7522.40 RPS

30 middleware
	7871.37 RPS

50 middleware
	7506.78 RPS

100 middleware
	6571.26 RPS

@asos-craigmorten
Copy link
Collaborator Author

The type_is package isn't a blocker as can use as-is because version 1.0.1 pulls in latest. Upgrading to 1.0.2 ironically uses older versions of std etc. which then cause problems. Will track ako-deno/type_is#2 and merge in separately.

@asos-craigmorten asos-craigmorten removed blocked help wanted Extra attention is needed wip labels Sep 17, 2020
@asos-craigmorten asos-craigmorten merged commit 3c3b968 into main Sep 17, 2020
@asos-craigmorten asos-craigmorten deleted the feat/deno-1.4.0-std-0.69.0 branch September 17, 2020 16:20
@asos-craigmorten asos-craigmorten linked an issue Sep 17, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Upgrade Opine to support Deno 1.4.0 and std 0.69.0
2 participants