Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade subprocess.run(universal_newlines=True) to subprocess.run(text=True) in --py37-plus #429

Merged
merged 1 commit into from
May 1, 2021
Merged

upgrade subprocess.run(universal_newlines=True) to subprocess.run(text=True) in --py37-plus #429

merged 1 commit into from
May 1, 2021

Conversation

MarcoGorelli
Copy link
Contributor

closes #336

@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 1, 2021 17:30
asottile
asottile reviewed May 1, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
pyupgrade/_plugins/universal_newlines_to_text.py Outdated Show resolved Hide resolved
pyupgrade/_plugins/universal_newlines_to_text.py Outdated
'subprocess',
('run',),
) and
not has_starargs(node)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there actually a problem with starargs here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, there's not - have removed and added a test!

asottile
asottile approved these changes May 1, 2021
View reviewed changes
Copy link
Owner

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 62f43a2 into asottile:master May 1, 2021
@MarcoGorelli MarcoGorelli deleted the universal_newlines_to_text branch May 1, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade subprocess.run(universal_newlines=True) to subprocess.run(text=True) in --py37-plus
2 participants
@MarcoGorelli @asottile