Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vue-tsc (type-checking on vue project) #207

Merged
merged 3 commits into from
May 11, 2023

Conversation

pattrickrice
Copy link
Contributor

@pattrickrice pattrickrice commented Apr 19, 2023

Please include a summary of your changes and link to the related issue(s).

  1. Adds type declaration outputs to vue component library
  2. fixes vue-tsc test (unblocked now that there are type declarations)
  3. refactors library to use Vite

Please also include relevant motivation and context.

Issue is reported here
#84

Type checking is a critical CI check for most projects and having a functional example is very useful for documentation.

You may delete parts of the template if they are obvious to all possible reviewers, e.g. the information is in the one-line description.

Type of change

  • Bug fix (change which fixes an issue)
  • New feature or functionality (change which adds functionality)
  • Style (white-space, formatting, etc...)
  • Refactor (a code change that neither fixes a bug or adds a new feature)
  • Performance (a code change that improves performance)
  • Documentation (updates to documentation or READMEs)
  • Chore (any other change that doesn't affect source or test files)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)
  • Relevant documentation has been updated
  • Suggested release notes are provided below:

Test plan

How has this been tested?

  • Covered by existing test cases
  • New test cases added
  • Manual testing

If part of the test plan included manual testing, please provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

bazel run :vite

Screenshot 2023-04-18 at 7 51 16 PM

Screenshot 2023-04-18 at 7 51 22 PM

@pattrickrice pattrickrice mentioned this pull request May 2, 2023
Copy link
Member

@jbedard jbedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @pattrickrice 👍

@jbedard jbedard merged commit 2685bb1 into aspect-build:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants