refactor: rename node_package to link_node_package #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
rename_rules
branch
2 times, most recently
from
bb1bdf4
to
68ac86a
Compare
|
This was meant to be a draft still as its based off of #48. Going to land that first and then rebase. |
|
looks like a stack on #48 - I'll review after the rebase |
gregmagolan
force-pushed
the
rename_rules
branch
from
68ac86a
to
a53b13e
Compare
…ck and npm_import)
gregmagolan
force-pushed
the
rename_rules
branch
from
a53b13e
to
25a41a3
Compare
alexeagle
approved these changes
Apr 29, 2022
| @@ -1,3 +1,3 @@ | |||
| docs/*.md linguist-generated=true | |||
| pnpm-lock.yaml linguist-generated=true | |||
| e2e/node_package/rules_foo/npm_repositories.bzl linguist-generated=true | |||
| e2e/link_node_package/rules_foo/npm_repositories.bzl linguist-generated=true | |||
There was a problem hiding this comment.
wonder if we should use a filename convention for vendored repositories.bzl files
There was a problem hiding this comment.
its too bad github doesn't recognize the @generated on the first line
"@generated by @aspect_rules_js//js/private:translate_pnpm_lock.bzl from pnpm lock file @rules_foo@rules_foo//foo:pnpm-lock.yaml"
eb574c9
to
25a41a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and
node_modules()macro tolink_node_packages()as this is more accurate and is future proof for linking Plug'n'Play which doesn't have anode_modulesfolder