feat: use rules_multitool #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
reviewed
Feb 25, 2024
jbedard
reviewed
Feb 25, 2024
alexeagle
changed the title
|
FYI @mark-thm |
So far this just replaces the most obvious subset of formatters that have four binaries for Mac/Linux x86_64/arm64. The pattern can be extended to provide more tools by default. We should NOT try to continue the pattern to anything that requires additional Bazel rules to provide a runtime, such as Prettier.
|
Oh there's still a bug in rules_multitool. I see that I'm downloading tools for all platforms rather than only for the host platform. @mark-thm want me to file an issue on the repo? |
|
@alexeagle it's unclear to me what the right behavior is here, but I threw together theoremlp/rules_multitool#12 as a candidate fix. |
it no longer fetches tools for all platforms"
|
That bug was fixed in theoremlp/rules_multitool#16 (thanks!) so this should be ready to go @jbedard |
|
Have you looked at the CI failures? |
|
You need 0.4.0 to resolve those (it contains the fix that allows you to have a top-level |
jbedard
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions from 1.0 API design review.
I'll followup with other provided tools in a subsequent PR after we are happy with the shape of this one.
Type of change
For changes visible to end-users
Test plan